Commit Graph

19 Commits

Author SHA1 Message Date
Ronan Keryell
ce70bc4d4e Add missing C: (composer), R: (rhythm) and X: fields and return error (#21)
* Add configuration for CMake build system alongside autoconf

- Add a modern CMake build system (`CMakeLists.txt`, `CMakePresets.json`) that coexists with the legacy
autoconf/Makefile build
- Shared source files (`midifile.c`, `parseabc.c`, `music_utils.c`, `parser2.c`) are compiled once via OBJECT
libraries and linked into the 8 binaries
- Three presets: `default` (Release), `debug`, `sanitize` (ASan + UBSan)
- Generates `compile_commands.json` for clangd/LSP editor support
- Install rules match the legacy Makefile (binaries, doc files, man pages)
- Pinned to `-std=gnu89` because the codebase mixes K&R `()` and ANSI typed prototypes — in C23/gnu23 (GCC 15+
default), `()` means `(void)`, making these a hard error. Note: **the existing autoconf build is also broken with
GCC 15** for the same reason

```sh
cmake --preset debug
cmake --build --preset debug
cmake --install build/debug --prefix /usr/local

Documentation

- README.md: added Building section with both autoconf and CMake instructions
- doc/readme.txt: added build instructions in the existing preamble
- doc/CHANGES: added changelog entry

Test plan

- All 3 presets configure and build with GCC 15
- Smoke test: abc2midi samples/coleraine.abc produces valid MIDI through mftext
- Sanitizer build (--preset sanitize) runs clean on sample files
- Install layout verified: 8 binaries, 10 doc files, 8 man pages in correct paths
- Build on macOS (untested, should work with AppleClang)

* Implement basic testing infrastructure

The CMake build includes a test suite covering all 8 programs:

- **Smoke tests** verify each binary runs cleanly with `-ver`.
- **Golden-file tests** run each program on a sample input and compare the
  (normalized) output to a checked-in reference. Binary MIDI outputs are
  piped through `mftext` to produce diffable text. Volatile lines (version
  banners, dates, temporary paths) are stripped before comparison.

```sh
ctest --preset debug

ctest --preset debug -L golden
ctest --preset debug -L smoke
```

To regenerate the golden files after an intentional behavioural change,
review the diff, then commit:

```sh
cmake --build build/debug --target update-golden
git diff tests/golden/
```

* Factorize more the test CMake code

* Add GitHub Action to run the CI and output a status badge

* Add GitHub Action workflow dispatch to allow running from the UI

* Now abc2midi exits 1 if an error occurs

Before it was always returning 0, hiding failures complicated to track in
complex build systems.

* Output missing C:, R: and X: headers as MIDI text meta-events

* Update changelog and comments

---------

Co-authored-by: Seymour Shlien <fy733@ncf.ca>
2026-04-22 07:58:22 -04:00
Ronan Keryell
c7f4015945 Add -PMAR option to emit MIDI marker meta-events for P: part labels (#16)
* Add -PMAR option to output `P:` information as MIDI part meta-event

* Update man page and comments

* Add the instance number of a part like `Part T-4`

This allows better tracking of parts played more than once with complex `P:`
header.

* Updated CHANGES file and added author change comments in the code
2026-04-01 07:12:55 -04:00
Henning Kiel
7b0b1cc77e ANSI function declarations 2025-10-02 15:54:33 +02:00
sshlien
9fa917b1bd 2023.12.23 2023-12-23 17:06:59 -05:00
Seymour Shlien
a9e10a7229 2022.01.22 2023-01-22 06:58:58 -05:00
Seymour Shlien
ff3200286b 2022.06.14 2022-06-14 14:46:35 -04:00
Seymour Shlien
47a0cecc5d 2022.03.20 2022-03-21 08:39:17 -04:00
Seymour Shlien
57a5ae2ba7 2022.02.13 2022-02-13 14:33:57 -05:00
Seymour Shlien
e58956238a 2022.01.28 2022-01-28 07:43:41 -05:00
Seymour Shlien
0b83ee2c7b 2022.01.27 2022-01-27 12:46:08 -05:00
Seymour Shlien
fb5479e801 2022.01.13 2022-01-13 18:08:38 -05:00
Seymour Shlien
402f1ba212 2021.12.12 2021-12-12 15:59:49 -05:00
Seymour Shlien
3e1306aa26 2021.12.10 2021-12-10 12:08:42 -05:00
Seymour Shlien
c9d2c0f33b 2021.09.15 2021-09-15 16:25:29 -04:00
Seymour Shlien
19fbb6b7e7 2021.06.27 2021-06-27 17:09:51 -04:00
Seymour Shlien
8079788c12 2021.04.26 2021-04-26 11:48:42 -04:00
Seymour Shlien
388fc83b86 2021.01.24 2021-01-25 11:36:07 -05:00
Seymour Shlien
e3e78e94f0 2020.aug.09 2020-08-18 13:54:11 -04:00
Seymour Shlien
0497c9a75b abcMIDI-2020.07.06.zip 2020-07-12 12:40:01 -04:00