Commit Graph

2 Commits

Author SHA1 Message Date
Ronan Keryell
ba603c3175 build: lower CMakePresets.json schema to v3 for older cmake compat (#27)
The preset file declared "version": 6 (cmake >= 3.25), causing
"Unrecognized 'version' field" on cmake releases as common as the
3.22.1 shipped by Ubuntu 22.04 LTS.  None of the v4/v5/v6 schema
features are used here -- the file only relies on
configurePresets/buildPresets/testPresets with cacheVariables,
binaryDir, displayName, output.outputOnFailure, and environment.
v3 (cmake >= 3.21) is the lowest schema where "generator" remains
optional so cmake can pick a default; v2 would have required adding
"generator" to every preset.

cmakeMinimumRequired lowered from 3.25 to 3.21 to match.

Verified locally that all three presets (default, debug, sanitize)
configure, build, and pass ctest --preset default (19/19 tests).

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-08 15:14:57 -04:00
Ronan Keryell
1d766a85d2 Implement basic testing infrastructure (#19)
* Add configuration for CMake build system alongside autoconf

- Add a modern CMake build system (`CMakeLists.txt`, `CMakePresets.json`) that coexists with the legacy
autoconf/Makefile build
- Shared source files (`midifile.c`, `parseabc.c`, `music_utils.c`, `parser2.c`) are compiled once via OBJECT
libraries and linked into the 8 binaries
- Three presets: `default` (Release), `debug`, `sanitize` (ASan + UBSan)
- Generates `compile_commands.json` for clangd/LSP editor support
- Install rules match the legacy Makefile (binaries, doc files, man pages)
- Pinned to `-std=gnu89` because the codebase mixes K&R `()` and ANSI typed prototypes — in C23/gnu23 (GCC 15+
default), `()` means `(void)`, making these a hard error. Note: **the existing autoconf build is also broken with
GCC 15** for the same reason

```sh
cmake --preset debug
cmake --build --preset debug
cmake --install build/debug --prefix /usr/local

Documentation

- README.md: added Building section with both autoconf and CMake instructions
- doc/readme.txt: added build instructions in the existing preamble
- doc/CHANGES: added changelog entry

Test plan

- All 3 presets configure and build with GCC 15
- Smoke test: abc2midi samples/coleraine.abc produces valid MIDI through mftext
- Sanitizer build (--preset sanitize) runs clean on sample files
- Install layout verified: 8 binaries, 10 doc files, 8 man pages in correct paths
- Build on macOS (untested, should work with AppleClang)

* Implement basic testing infrastructure

The CMake build includes a test suite covering all 8 programs:

- **Smoke tests** verify each binary runs cleanly with `-ver`.
- **Golden-file tests** run each program on a sample input and compare the
  (normalized) output to a checked-in reference. Binary MIDI outputs are
  piped through `mftext` to produce diffable text. Volatile lines (version
  banners, dates, temporary paths) are stripped before comparison.

```sh
ctest --preset debug

ctest --preset debug -L golden
ctest --preset debug -L smoke
```

To regenerate the golden files after an intentional behavioural change,
review the diff, then commit:

```sh
cmake --build build/debug --target update-golden
git diff tests/golden/
```

* Factorize more the test CMake code
2026-04-22 07:42:29 -04:00