Emitting a Marker meta-event from the PART case wrote the event with
delta_time_track0 (correct, since that's the conductor-track accumulator)
but did not also reset delta_time. On track 0 in multi-track mode,
delta_time also accumulates via timestep() and is what writetrack()
returns to the MIDI library as the end-of-track delta — so each marker
left a stale delta_time that pushed the end-of-track event past the end
of the music. In single-track mode (ntracks == 1), markers were written
with delta_time_track0 too, but delta_time is the only relevant counter
in that mode, so notes following each marker were shifted later.
Fix: mirror the TEMPO handler — on ntracks == 1 use delta_time and reset
it; on ntracks != 1 keep using delta_time_track0 for the event delta but
also zero delta_time so the end-of-track is not inflated.
Reported by James Allwright with the partdemo.abc test case (now in
samples/), which exercises the parts != -1 path (header P:BACDBAC plus
body P: labels A/B/C/D). James independently fixed the same bug in his
abc2midiu fork in r32 (commit 34b7c32, "Add -PMAR option for part
markers"), where the equivalent reset is on the single delta_time
counter — his fork having retired delta_time_track0 in an earlier
refactor. Verified that mftext output of the generated MIDI is now
byte-identical to the non-PMAR output except for the added Marker
events, on both partdemo.abc (single-track) and samples/demo.abc tune 5
with P:(AB)3 (multi-track).
Add a CMake/CTest regression test (abc2midi_pmar_partdemo) that locks in
the post-fix mftext output. To support it, add_golden_test() gains an
optional NAME (to register multiple tests against the same TYPE+SAMPLE
pair) and an optional ABC2MIDI_ARGS (forwarded to the abc2midi
invocation in run_via_mid). Reverting the genmidi.c fix makes the new
test fail; reapplying it makes it pass.
* Add configuration for CMake build system alongside autoconf
- Add a modern CMake build system (`CMakeLists.txt`, `CMakePresets.json`) that coexists with the legacy
autoconf/Makefile build
- Shared source files (`midifile.c`, `parseabc.c`, `music_utils.c`, `parser2.c`) are compiled once via OBJECT
libraries and linked into the 8 binaries
- Three presets: `default` (Release), `debug`, `sanitize` (ASan + UBSan)
- Generates `compile_commands.json` for clangd/LSP editor support
- Install rules match the legacy Makefile (binaries, doc files, man pages)
- Pinned to `-std=gnu89` because the codebase mixes K&R `()` and ANSI typed prototypes — in C23/gnu23 (GCC 15+
default), `()` means `(void)`, making these a hard error. Note: **the existing autoconf build is also broken with
GCC 15** for the same reason
```sh
cmake --preset debug
cmake --build --preset debug
cmake --install build/debug --prefix /usr/local
Documentation
- README.md: added Building section with both autoconf and CMake instructions
- doc/readme.txt: added build instructions in the existing preamble
- doc/CHANGES: added changelog entry
Test plan
- All 3 presets configure and build with GCC 15
- Smoke test: abc2midi samples/coleraine.abc produces valid MIDI through mftext
- Sanitizer build (--preset sanitize) runs clean on sample files
- Install layout verified: 8 binaries, 10 doc files, 8 man pages in correct paths
- Build on macOS (untested, should work with AppleClang)
* Implement basic testing infrastructure
The CMake build includes a test suite covering all 8 programs:
- **Smoke tests** verify each binary runs cleanly with `-ver`.
- **Golden-file tests** run each program on a sample input and compare the
(normalized) output to a checked-in reference. Binary MIDI outputs are
piped through `mftext` to produce diffable text. Volatile lines (version
banners, dates, temporary paths) are stripped before comparison.
```sh
ctest --preset debug
ctest --preset debug -L golden
ctest --preset debug -L smoke
```
To regenerate the golden files after an intentional behavioural change,
review the diff, then commit:
```sh
cmake --build build/debug --target update-golden
git diff tests/golden/
```
* Factorize more the test CMake code
* Add GitHub Action to run the CI and output a status badge
* Add GitHub Action workflow dispatch to allow running from the UI
* Now abc2midi exits 1 if an error occurs
Before it was always returning 0, hiding failures complicated to track in
complex build systems.
* Output missing C:, R: and X: headers as MIDI text meta-events
* Update changelog and comments
---------
Co-authored-by: Seymour Shlien <fy733@ncf.ca>
* Add -PMAR option to output `P:` information as MIDI part meta-event
* Update man page and comments
* Add the instance number of a part like `Part T-4`
This allows better tracking of parts played more than once with complex `P:`
header.
* Updated CHANGES file and added author change comments in the code
