richard/abcmidi
1
0
Fork 0
mirror of https://github.com/sshlien/abcmidi.git synced 2026-02-04 04:38:10 +00:00
Code Issues Projects Releases Wiki Activity

2023.12.23

Browse Source
This commit is contained in:
sshlien
2023-12-23 17:06:59 -05:00
parent 0dd1e063ae
commit 9fa917b1bd
5 changed files with 48 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
doc/CHANGES
View File

@@ -15151,3 +15151,37 @@ copying it to disk.
midistats: Introducing a new option -nseqfor n where is a channel
number. See drums.txt for a description.
December 23 2023
abc2midi: gchord bug
The following example produces some strange artefacts on starting
the midi file for some players.
X:1
T:Test
L:1/8
Q:1/2=30
M:2/2
%%MIDI gchord GHIc
K:C
GAB | "C"c4 C4 |
Explanation: the output midi file plays a note with midi pitch 0
in the accompaniment channel. The problem originates in the dogchords()
function for switch case 'G': in genmidi.c. Since g_started is 0,
the second branch of the if statement is executed, but the pitch
value in gchordnotes[gchordnotes_size] contains 0.
Fix: the switch statement should not be executed since g_started is
0 (i.e. the gchord accompaniment does not start till "C" is encountered).
The switch statement is now bypassed when either g_started
or gchords is 0. The tests for gchords and g_started in all the
case statements were removed since they are unnecessary.