richard/abcmidi
1
0
Fork 0
mirror of https://github.com/sshlien/abcmidi.git synced 2026-05-30 20:09:29 +00:00
Code Issues Projects Releases Wiki Activity

Implement basic testing infrastructure (#19)

Browse Source 
* Add configuration for CMake build system alongside autoconf

- Add a modern CMake build system (`CMakeLists.txt`, `CMakePresets.json`) that coexists with the legacy
autoconf/Makefile build
- Shared source files (`midifile.c`, `parseabc.c`, `music_utils.c`, `parser2.c`) are compiled once via OBJECT
libraries and linked into the 8 binaries
- Three presets: `default` (Release), `debug`, `sanitize` (ASan + UBSan)
- Generates `compile_commands.json` for clangd/LSP editor support
- Install rules match the legacy Makefile (binaries, doc files, man pages)
- Pinned to `-std=gnu89` because the codebase mixes K&R `()` and ANSI typed prototypes — in C23/gnu23 (GCC 15+
default), `()` means `(void)`, making these a hard error. Note: **the existing autoconf build is also broken with
GCC 15** for the same reason

```sh
cmake --preset debug
cmake --build --preset debug
cmake --install build/debug --prefix /usr/local

Documentation

- README.md: added Building section with both autoconf and CMake instructions
- doc/readme.txt: added build instructions in the existing preamble
- doc/CHANGES: added changelog entry

Test plan

- All 3 presets configure and build with GCC 15
- Smoke test: abc2midi samples/coleraine.abc produces valid MIDI through mftext
- Sanitizer build (--preset sanitize) runs clean on sample files
- Install layout verified: 8 binaries, 10 doc files, 8 man pages in correct paths
- Build on macOS (untested, should work with AppleClang)

* Implement basic testing infrastructure

The CMake build includes a test suite covering all 8 programs:

- **Smoke tests** verify each binary runs cleanly with `-ver`.
- **Golden-file tests** run each program on a sample input and compare the
  (normalized) output to a checked-in reference. Binary MIDI outputs are
  piped through `mftext` to produce diffable text. Volatile lines (version
  banners, dates, temporary paths) are stripped before comparison.

```sh
ctest --preset debug

ctest --preset debug -L golden
ctest --preset debug -L smoke
```

To regenerate the golden files after an intentional behavioural change,
review the diff, then commit:

```sh
cmake --build build/debug --target update-golden
git diff tests/golden/
```

* Factorize more the test CMake code
This commit is contained in:
Ronan Keryell
2026-04-22 04:42:29 -07:00
committed by GitHub
parent c7f4015945
commit 1d766a85d2
18 changed files with 8421 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

148
tests/golden/midi2abc_coleraine.txt Normal file
View File

@@ -0,0 +1,148 @@
calling midi2abc
X: 1
T: from midi2abc_coleraine.mid
M: 6/8
L: 1/8
Q:1/4=142
K:C % 0 sharps
V:1
%%MIDI program 26
%%MIDI program 72
EE>A AAB| \
cB>e ee2| \
dc>A AAB| \
cB^G EE2|
EE>A AAB| \
cB>e ee2| \
dc>B AB^G| \
EA4-A|
EE>A AAB| \
cB>e ee2| \
dc>A AAB| \
cB^G EE2|
EE>A AAB| \
cB>e ee2| \
dc>B AB^G| \
EA4-A|
Bc2 ccd| \
cBd gg2| \
^ga>e dcB| \
A^GB GE^F|
^GAG ABA| \
Bcd efe| \
dc>B AB^G| \
EA4-A|
Bc2 ccd| \
cBd gg2| \
^ga>e dcB| \
A^GB GE^F|
^GAG ABA| \
Bcd efe| \
dc>B AB^G| \
EA4-A|
V:2
%%MIDI program 3
%%MIDI program 3
E,,A,,z [ECA,]A,,z| \
[ECA,]E,,z [DB,^G,E,]E,,z| \
[DB,^G,E,]A,,z [ECA,]A,,z| \
[ECA,]E,,z [DB,^G,E,]E,,z|
[DB,^G,E,]A,,z [ECA,]A,,z| \
[ECA,]E,,z [DB,^G,E,]E,,z| \
[DB,^G,E,]A,,z [ECA,]E,,z| \
[DB,^G,E,]A,,z [ECA,]A,,z|
[DB,^G,E,]A,,z [ECA,]A,,z| \
[ECA,]E,,z [DB,^G,E,]E,,z| \
[DB,^G,E,]A,,z [ECA,]A,,z| \
[ECA,]E,,z [DB,^G,E,]E,,z|
[DB,^G,E,]A,,z [ECA,]A,,z| \
[ECA,]E,,z [DB,^G,E,]E,,z| \
[DB,^G,E,]A,,z [ECA,]E,,z| \
[DB,^G,E,]A,,z [ECA,]A,,z|
[FDB,G,]C,,z [G,E,C,]C,,z| \
[G,E,C,]G,,z [DB,G,]E,,z| \
[B,^G,E,]A,,z [ECA,]A,,z| \
[ECA,]E,,z [DB,^G,E,]E,,z|
[DB,^G,E,]A,,z [ECA,]E,,z| \
[DB,^G,E,]A,,z [ECA,]D,,z| \
[A,F,D,]A,,z [ECA,]E,,z| \
[DB,^G,E,]A,,z [ECA,]A,,z|
[FDB,G,]C,,z [G,E,C,]C,,z| \
[G,E,C,]G,,z [DB,G,]E,,z| \
[B,^G,E,]A,,z [ECA,]A,,z| \
[ECA,]E,,z [DB,^G,E,]E,,z|
[DB,^G,E,]A,,z [ECA,]E,,z| \
[DB,^G,E,]A,,z [ECA,]D,,z| \
[A,F,D,]A,,z [ECA,]E,,z| \
[DB,^G,E,]A,,z [ECA,]A,,
V:3
%%MIDI channel 10
%%clef bass
FFz ^F/2F/2D,F| \
^F=Fz ^F/2F/2D,F| \
^F=Fz ^F/2F/2D,F| \
^F=Fz ^F/2F/2D,F|
^F=Fz ^F/2F/2D,F| \
^F=Fz ^F/2F/2D,F| \
^F=Fz ^F/2F/2D,F| \
^F=Fz ^F/2F/2D,F|
^F=Fz ^F/2F/2D,F| \
^F=Fz ^F/2F/2D,F| \
^F=Fz ^F/2F/2D,F| \
^F=Fz ^F/2F/2D,F|
^F=Fz ^F/2F/2D,F| \
^F=Fz ^F/2F/2D,F| \
^F=Fz ^F/2F/2D,F| \
^F=Fz ^F/2F/2D,F|
^F=Fz ^F/2F/2D,F| \
^F=Fz ^F/2F/2D,F| \
^F=Fz ^F/2F/2D,F| \
^F=Fz ^F/2F/2D,F|
^F=Fz ^F/2F/2D,F| \
^F=Fz ^F/2F/2D,F| \
^F=Fz ^F/2F/2D,F| \
^F=Fz ^F/2F/2D,F|
^F=Fz ^F/2F/2D,F| \
^F=Fz ^F/2F/2D,F| \
^F=Fz ^F/2F/2D,F| \
^F=Fz ^F/2F/2D,F|
^F=Fz ^F/2F/2D,F| \
^F=Fz ^F/2F/2D,F| \
^F=Fz ^F/2F/2D,F| \
^F=Fz ^F/2F/2D,F|
V:4
%%MIDI channel 10
zG,,3/2A,,/2 G,,A,,/2G,,/2A,,| \
A,,G,,3/2A,,/2 G,,A,,G,,/2A,,/2| \
G,,G,,3/2A,,/2 G,,A,,/2G,,/2A,,| \
A,,G,,3/2A,,/2 G,,A,,G,,/2A,,/2|
G,,G,,3/2A,,/2 G,,A,,/2G,,/2A,,| \
A,,G,,3/2A,,/2 G,,A,,G,,/2A,,/2| \
G,,G,,3/2A,,/2 G,,A,,/2G,,/2A,,| \
A,,G,,3/2A,,/2 G,,A,,G,,/2A,,/2|
zG,,3/2A,,/2 G,,A,,/2G,,/2A,,| \
A,,G,,3/2A,,/2 G,,A,,G,,/2A,,/2| \
G,,G,,3/2A,,/2 G,,A,,/2G,,/2A,,| \
A,,G,,3/2A,,/2 G,,A,,G,,/2A,,/2|
G,,G,,3/2A,,/2 G,,A,,/2G,,/2A,,| \
A,,G,,3/2A,,/2 G,,A,,G,,/2A,,/2| \
G,,G,,3/2A,,/2 G,,A,,/2G,,/2A,,| \
A,,G,,3/2A,,/2 G,,A,,G,,/2A,,/2|
z
K:F# % 6 sharps
=G,,3/2=A,,/2 G,,A,,/2G,,/2A,,| \
=A,,=G,,3/2A,,/2 G,,A,,G,,/2A,,/2| \
=G,,G,,3/2=A,,/2 G,,A,,/2G,,/2A,,| \
=A,,=G,,3/2A,,/2 G,,A,,G,,/2A,,/2|
=G,,G,,G,, G,,z2| \
z=G,,G,, G,,z2| \
z=G,,G,, G,,z2| \
z=G,,3z2|
z=G,,3/2=A,,/2 G,,A,,/2G,,/2A,,| \
=A,,=G,,3/2A,,/2 G,,A,,G,,/2A,,/2| \
=G,,G,,3/2=A,,/2 G,,A,,/2G,,/2A,,| \
=A,,=G,,3/2A,,/2 G,,A,,G,,/2A,,/2|
=G,,G,,G,, G,,z2| \
z=G,,G,, G,,z2| \
z=G,,G,, G,,z2| \
z=G,,3